seanjmullan commented on code in PR #204:
URL:
https://github.com/apache/santuario-xml-security-java/pull/204#discussion_r1318773801
##########
src/test/java/org/apache/xml/security/test/dom/signature/SignatureTest.java:
##########
@@ -93,13 +96,18 @@ void testSigningVerifyingFromExistingSignature() throws
Throwable {
@Test
void testSigningVerifyingFromExistingSignatureWithProvider() throws
Throwable {
- Provider provider = new
org.bouncycastle.jce.provider.BouncyCastleProvider();
- Document doc = getOriginalDocument();
- XMLSignature signature = signDocument(doc, provider);
- assertEquals(provider.getName(),
signature.getSignedInfo().getSignatureAlgorithm().getJCEProviderName());
-
- PublicKey pubKey = getPublicKey();
- assertTrue(signature.checkSignatureValue(pubKey));
+ try {
+ Class<?> bouncyCastleProviderClass =
Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider");
+ Provider provider =
(Provider)bouncyCastleProviderClass.getConstructor().newInstance();
+ Document doc = getOriginalDocument();
+ XMLSignature signature = signDocument(doc, provider);
+ assertEquals(provider.getName(),
signature.getSignedInfo().getSignatureAlgorithm().getJCEProviderName());
+
+ PublicKey pubKey = getPublicKey();
+ assertTrue(signature.checkSignatureValue(pubKey));
+ } catch (ReflectiveOperationException e) {
+ // BouncyCastle not installed, ignore
+ }
}
Review Comment:
Same comment here as before.
##########
src/test/java/org/apache/xml/security/test/dom/signature/SignatureTest.java:
##########
@@ -69,17 +66,23 @@ void testSigningVerifyingFromRebuildSignature() throws
Throwable {
@Test
void testSigningVerifyingFromRebuildSignatureWithProvider() throws
Throwable {
- Provider provider = new
org.bouncycastle.jce.provider.BouncyCastleProvider();
- Document doc = getOriginalDocument();
- XMLSignature signature = signDocument(doc, provider);
- assertEquals(provider.getName(),
signature.getSignedInfo().getSignatureAlgorithm().getJCEProviderName());
-
- Element signatureElem = (Element) doc.getElementsByTagNameNS(DS_NS,
"Signature").item(0);
- signature = new XMLSignature(signatureElem, "", provider);
- assertEquals(provider.getName(),
signature.getSignedInfo().getSignatureAlgorithm().getJCEProviderName());
-
- PublicKey pubKey = getPublicKey();
- assertTrue(signature.checkSignatureValue(pubKey));
+ try {
+ Class<?> bouncyCastleProviderClass =
Class.forName("org.bouncycastle.jce.provider.BouncyCastleProvider");
+ Provider provider =
(Provider)bouncyCastleProviderClass.getConstructor().newInstance();
+
+ Document doc = getOriginalDocument();
+ XMLSignature signature = signDocument(doc, provider);
+ assertEquals(provider.getName(),
signature.getSignedInfo().getSignatureAlgorithm().getJCEProviderName());
+
+ Element signatureElem = (Element)
doc.getElementsByTagNameNS(DS_NS, "Signature").item(0);
+ signature = new XMLSignature(signatureElem, "", provider);
+ assertEquals(provider.getName(),
signature.getSignedInfo().getSignatureAlgorithm().getJCEProviderName());
+
+ PublicKey pubKey = getPublicKey();
+ assertTrue(signature.checkSignatureValue(pubKey));
+ } catch (ReflectiveOperationException e) {
+ // BouncyCastle not installed, ignore
+ }
}
Review Comment:
Same comment here as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
