seanjmullan commented on code in PR #240:
URL:
https://github.com/apache/santuario-xml-security-java/pull/240#discussion_r1380629008
##########
src/main/java/org/apache/xml/security/algorithms/implementations/SignatureBaseRSA.java:
##########
@@ -62,7 +62,7 @@ public SignatureBaseRSA(Provider provider) throws
XMLSignatureException {
String algorithmID =
JCEMapper.translateURItoJCEID(this.engineGetURI());
this.signatureAlgorithm = getSignature(provider, algorithmID);
LOG.log(Level.DEBUG, "Created SignatureRSA using {0} and provider {1}",
- algorithmID, signatureAlgorithm.getProvider());
+ algorithmID, provider);
Review Comment:
Good catch, I understand the problem, sorry for not detecting this when I
fixed this.
I would just restore the prior code and do not include the provider in the
log message, because provider can be null and in that case doesn't really make
sense for the log message as I was trying to log the provider that was chosen.
So change back to:
`LOG.debug("Created SignatureRSA using {}", algorithmID);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
