phax commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1384763142
##########
src/test/java/org/apache/xml/security/testutils/KeyTestUtils.java:
##########
@@ -101,6 +104,15 @@ public static KeyPair generateKeyPair(KeyUtils.KeyType
keyType) throws NoSuchAlg
return keyPairGenerator.generateKeyPair();
}
+ public static KeyPair generateKeyPairIfSupported(KeyUtils.KeyType keyType){
+ KeyPair keyPair = null;
+ try {
+ keyPair = generateKeyPair(keyType);
+ } catch (NoSuchAlgorithmException | InvalidAlgorithmParameterException
| InvalidParameterSpecException e) {
+ LOG.log(DEBUG, "Key algorithm [{0}]] is not supported! Error
message: [{}]", keyType, e.getMessage());
Review Comment:
You are mixing the log formatting here. Please replace `{}` with `{1}`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
