seanjmullan commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1410830573
##########
src/main/java/org/apache/xml/security/encryption/AgreementMethod.java:
##########
@@ -88,6 +91,22 @@ public interface AgreementMethod {
*/
void setKANonce(byte[] kanonce);
+
+ /**
+ * Returns KeyDerivationMethod information used in the
<code>AgreementMethod</code>.
+ * @return The KeyDerivationMethod information regarding the
<code>AgreementMethod</code>.
+ */
+ KeyDerivationMethod getKeyDerivationMethod() throws XMLSecurityException;
Review Comment:
I think that is a different issue that doesn't affect these changes.
`XMLCipher` is final, so we don't need to worry about breaking existing
implementations of `XMLCipher` that don't implement these methods since
Santuario provides the only one. I guess it's more of a general question - if
applications want to use these new methods, they will need to use a specific
version of Santuario that has them - I guess that's fine. I don't know how
formal of a release policy we have for new APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
