jrihtarsic commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1417600662
##########
src/main/java/org/apache/xml/security/keys/content/DEREncodedKeyValue.java:
##########
@@ -37,7 +37,9 @@
public class DEREncodedKeyValue extends Signature11ElementProxy implements
KeyInfoContent {
/** JCA algorithm key types supported by this implementation. */
- private static final String[] supportedKeyTypes = { "RSA", "DSA", "EC"};
+ private static final String[] supportedKeyTypes = { "RSA", "DSA", "EC",
Review Comment:
My initial focus was to add ECDH support with (X)EC keys. But I agree that
we can also add the missing two key types for DEREncodedKeyValue since I
already changing this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]