seanjmullan commented on code in PR #234:
URL:
https://github.com/apache/santuario-xml-security-java/pull/234#discussion_r1431436720
##########
src/main/java/org/apache/xml/security/keys/content/KeyValue.java:
##########
@@ -116,6 +115,20 @@ public KeyValue(Document doc, PublicKey pk) {
}
}
+ /**
+ * Method getPublicKey verifies that the key xml KeyValue encoding is
supported for the given key type. If the
+ * encoding is supported, it returns true else false.
+ *
+ * @return the public key type can be KeyValue encoding is supported then
it returns true else false
Review Comment:
This sentence is hard to parse. Suggest "@return true if the public key has
a KeyValue encoding, false otherwise"
##########
src/main/java/org/apache/xml/security/keys/content/KeyValue.java:
##########
@@ -116,6 +115,20 @@ public KeyValue(Document doc, PublicKey pk) {
}
}
+ /**
+ * Method getPublicKey verifies that the key xml KeyValue encoding is
supported for the given key type. If the
Review Comment:
s/Method getPublicKey verifies/Verifies/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
