Michael Meeks wrote:
I attach the 'obvious' patch saving only ~40 lines, small of course but
perhaps worthwhile, I assume that the hot path here is to hit
CreateStringFromTokenArray - which does the same trick in it's own
implementation. [ edited in emacs, and possibly broken as a patch ]. Of
course, you'll be able to think of a better name for DoEnglishFoo ;-)
The "obvious" part of it is to implement the "String" method using the
"OUStringBuffer" one. This seems right, and on average, it might even be
faster that way. Merging 4 lines into a separate function seems a bit
excessive though.
Also, the whole thing overlaps with Jody's R1C1 stuff (easily recognized
by the "conv" parameter which conflicts our naming guidelines), so maybe
we should wait for integration of scr1c1.
P.S. Should I add a sentence here about our mailing lists working better
if you're subscribed?
Yep ;-) sounds good. I guess I dislike '[EMAIL PROTECTED]' - and I've
not really used this list before /me is trying to engage with the
collab.net monster; I've updated my SourceCast mail source - *hopefully*
that'll improve things; let me know.
Your mail got through the list without moderation. So you are now
subscribed with a current address and no longer need to be cc'ed?
Niklas
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
