Noel Power wrote:
so, I'd just like to;
a) let people know I am doing this
b) let people to be able to have a look at the changes in order to
determine whether those changes will create any problems.
I've taken the trouble to extract the patches from the cws and split
them as follows

http://go-oo.org/~ooo/cws-npower6/sc.diff ( changes to existing sc
files )

The "SC_DLLPUBLIC" changes look right. Of course, the long-term goal should be to have everything you need available in our API, so these changes wouldn't be necessary. We're in a similar situation with the new Excel import filter, which is in a separate module (see Daniel's blog entry at http://blogs.sun.com/GullFOSS/entry/office_open_xml_import_filter). We're going to expand the API as needed there. But that's in a separate child workspace, so for your VBA stuff, it's probably best to integrate it as-is and change it to API usage later.

Note that there is a macro "ISCLIB", so you don't need the platform .IF in the makefile to link against sc. Do you really need to link against the scui lib? If needed, that would seem wrong.

Also note that CWS "calcwarnings" will be integrated very soon, after which warnings will be errors in module sc (for the Hamburg-built platforms). Of course, without the changes in "calcwarnings", there are many warnings from Calc's header files, so if you don't want to manually sort out which warnings are yours, you'll have to resync to a milestone that includes "calcwarnings".

http://go-oo.org/~ooo/cws-npower6/sc-vbamodule.diff ( the vba directory,
it's not necessary to inspect this ( except for perhaps the
makefile.mk ), but its there for completeness

p.s. by default the env variable ENABLE_VBA & VBA_EXTENSION which
control the building of the component are set to 'NO' by default

Please let me know if there are any issues or concerns, I want to put
this cws to bed asap as there are many many more cws(s) to be built
ontop of this one.

How complete is this now? Is it already considered a QA-able feature, or is it just preparation for other CWSes?

Niklas

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to