Kohei Yoshida wrote:
I'd like get your input on the new UNO API that I have introduced as
part of implementing the multi-string filter.  The relevant issue page
is here:

  http://qa.openoffice.org/issues/show_bug.cgi?id=77677

Currently, Calc only has one type of sheet filter, which is represented
by com.sun.star.sheet.TableFilterField.  And it is read from & written
to the document model all at once via getFilterFields and
setFilterFields in the XSheetFilterDescriptor interface.  Multiple
instances of this data are contained in css::uno::Sequence.

Because I needed to allow reading and writing of filters of different
types, which the current API doesn't allow, I created a new set of API
just for this.  Let me summarize the new API below.

TableFilterField and TableFilterFieldNormal would then be two structs for basically the same thing. Also, First/Next-style iteration is usually done through a createEnumeration method, where it's clear that each call returns a new object with separate enumeration state. Why don't we keep the new interface similar to the old one, with get/set for a sequence of fields, either with a new struct containing all field options, or with an any containing the old or new struct?

I also don't think we should integrate this without having UI for it. That would result in "hidden state", where a filter behaves in an unexpected way and the user can't see why.

Niklas

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to