Lvyue, Can you attach your next patch in unified diff (as in 'diff -up files...')? It will be easier for reading/reviewing.
Thanks, Muthu Subramanian > > ---------- Forwarded message ---------- > From: "Lvyue" <[EMAIL PROTECTED]> > To: "[email protected]" <[email protected]> > Date: Tue, 18 Dec 2007 15:20:21 +0800 > Subject: Re: [sc-dev] Patch for i38759 > Hi, Eike > > I have submitted the third patch, please check it. > :) > > > > Lvyue > 2007-12-12 > > > > ---------- Forwarded message ---------- > From: Eike Rathke <[EMAIL PROTECTED]> > To: [email protected] > Date: Tue, 18 Dec 2007 15:52:01 +0100 > Subject: Re: [sc-dev] Patch for i38759 > Hi Lvyue, > > On Tuesday, 2007-12-18 15:20:21 +0800, Lvyue wrote: > > > I have submitted the third patch, please check it. > > Better, but not to the point. Maybe there's still some misunderstanding > about what the outcome should be. With the patch the function currently > treats bEmptyCells=true if already only one of the parameters does not > evaluate as a value (or text with bTextAsZero==true). Instead, only if > all parameters do not contain any value the condition of returning > 0 unconditionally should be met. So, > > =MAX(A1:A2;B1:B2) > > should result in the maximum value of A1:A2 if the range B1:B2 does not > contain numeric value cells. > > Btw, in the case of svString the SetError(errIllegalParameter) should > not be replaced. Passing a literal string to MIN/MAX (as opposed to > MINA/MAXA) should still result in an error. > > Eike > > -- > OOo/SO Calc core developer. Number formatter stricken i18n transpositionizer. > SunSign 0x87F8D412 : 2F58 5236 DB02 F335 8304 7D6C 65C9 F9B5 87F8 D412 > OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS > Please don't send personal mail to the [EMAIL PROTECTED] account, which I > use for > mailing lists only and don't read from outside Sun. Use [EMAIL PROTECTED] > Thanks. > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
