Hi there, So, I've just completed my work toward removing unused methods from the sc module based on Caolan's callcatcher output. The CWS has been set ready for QA, and Oliver was kind enough to take on the task of QA'ing this CWS.
Here is the summary of what I've done: 1) Removed the old binary filter related code that was not used by anybody else. This includes those Load, Save, Store etc. methods that almost every single core class had. 2) Introduced OLD_PIVOT_IMPLEMENTATION pre-processor macro to disable the code that was only relevant to the old pivot table implementation, which is now superseded by the datapilot implementation (hence no longer necessary). I didn't remove it at this time, but I'd like us to remove this code at a later time after a certain period of time unless someone objects. 3) Introduced ENABLE_LOTUS123_EXPORT macro to disable the WK1 export filter code. 4) Commented out all the other unused methods with //UNUSED2008-05. I put a date in the tag so that we'll know how long the code has been commented out, to help us identify the age of the commented out code. I would like to then create a follow-up CWS to remove these commented lines permanently at some point in the future. Meanwhile, if you come across code that is commented out with the UNUSED2008-05 tag, please either remove it permanently if you are certain that the code is no longer needed, or uncomment it if you still need it. Regarding 1), I was not able to remove some of those Load() Store() methods because some code still actively use it for non-binfilter related stuff. For instance..., * ScDocument::CopyDdeLinks(...) still uses the Load(), Store() methods. This prevents certain Load(), Store() methods from being removed. This is called from ScTransferObj::InitDocShell(). * XclExpChangeTrack::CreateTempChangeTrack() still calls ScChangeTrack's Store() and Load() methods which also calls other class'es Store() and Load() methods. I'm not really sure if these uses are still active, or just a leftover of earlier functionality. But if we can remove these uses, then we could remove even more Load(), Store() methods from Calc's code. Lastly, I didn't remove any of VBA's unused methods, because the code in the upstream tree is not up-to-date, and Noel has volunteered to take care of it on the ooo-build side. So, that area is untouched for now. That's all for now. Thanks for reading. :-) Kohei -- Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc. <[EMAIL PROTECTED]> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
