Hi Daniel, On Tue, 2009-04-07 at 20:50 +0200, Daniel Rentz wrote: > Hello, > > Kohei Yoshida schrieb: > > > > Great! BTW, the new security framework would probably affect the > > password input UI part, but should not affect anything else IMO. > > Btw, I am interested in the pw input UI stuff to add it to the ooxml > filter. Do you have a pointer for me?
Sure. I think there are two parts to the password input UI that I should mention. First, to enable password entry in the file picker dialog, currently we hard-code the filter name in struct CheckPasswordCapability in sfx2 (in sfx2/source/dialog/filedlghelper.cxx). But if the number of filter that supports export encryption grows, it will probably make sense to create a per-filter flag for this so that the password capability can be controlled in the configuration files in the filter module. I believe Mikhail shares this opinion as well (as we talked about this previously). Secondly, the actual password input UI is what has changed recently (since m38?). Since Excel's encryption password has a limitation of 0 to 15 character in length, we need to add that restriction somehow in the new security framework. I asked about this on the [email protected] list and here is the whole thread we had back then: http://framework.openoffice.org/servlets/BrowseList?list=dev&by=thread&from=2170560 In the old implementation, it was covered by SfxPasswordDialog, and it was quite easy to modify that class to add the aforementioned restriction. But in the new framework, that part is encapsulated into its own module via UNO API, so a new strategy is needed. Unfortunately I don't know any more than what we discussed on this thread since I sort of procrastinated on this. ;-) I hope this pointer is useful for you. Kohei -- Kohei Yoshida - OpenOffice.org Engineer - Novell, Inc. <[email protected]> --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
