On 05/04/09 16:52, Kohei Yoshida wrote:
Inspired by this blog post by Caolan:

http://blogs.linux.ie/caolan/2009/05/02/dev300_m47/

I would like to work on the 2nd round of unused code removal in sc
module.

Issue 95953 already has a patch removing some of them.

I'd like to approach it in a way similar to how I did it in the first
round, as follows:

1) comment out unused methods with //UNUSED_200905, and only remove
those methods that are obviously not needed or very trivial to
re-implement (i.e. methods that only have a few lines of code, methods
that are file-scope local, methods that are used only for binfilter
etc.).

2) remove methods that have been commented out during the previous
removal effort (those prefixed with //UNUSED_200805).

If there are no objections, I'd like to start this sometime soon.

What do you think?

I'd prefer to do the second step manually, i.e. after understanding why a method was added once and why it is no longer needed.

Niklas

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to