[ 
https://issues.apache.org/jira/browse/SDAP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389971#comment-16389971
 ] 

ASF GitHub Bot commented on SDAP-35:
------------------------------------

lewismc commented on a change in pull request #6: SDAP-35 (completed the 
configuration change)
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172927334
 
 

 ##########
 File path: 
core/src/main/java/org/apache/sdap/mudrod/metadata/structure/MetadataExtractor.java
 ##########
 @@ -67,15 +67,15 @@ public MetadataExtractor() {
    * @param type  metadata type name
    * @return metadata list
    */
-  protected List<PODAACMetadata> loadMetadataFromES(ESDriver es, String index, 
String type) {
+  protected List<Metadata> loadMetadataFromES(ESDriver es, String index, 
String type) {
 
-    List<PODAACMetadata> metadatas = new ArrayList<PODAACMetadata>();
+    List<Metadata> metadatas = new ArrayList<Metadata>();
 
 Review comment:
   Just use the diamond type operator no need to dual define the type. Should be
   ```
   List<Metadata> metadatas = new ArrayList<>();
   ```
   I would also suggest that you change the variable name to something more 
description such as ```metadataList```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Overhaul MUDROD configuration
> -----------------------------
>
>                 Key: SDAP-35
>                 URL: https://issues.apache.org/jira/browse/SDAP-35
>             Project: Apache Science Data Analytics Platform
>          Issue Type: Task
>          Components: mudrod
>            Reporter: Lewis John McGibbney
>            Priority: Major
>
> [~Yongyao] please augment the description here with your intended patch as 
> per https://github.com/aist-oceanworks/mudrod/pull/215
> Also, please name your branch and commit message after the issue you create 
> in JIRA. It makes things much easier as we try to improve the quality of our 
> source code review and development workflow. Thank you



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to