[
https://issues.apache.org/jira/browse/SDAP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389977#comment-16389977
]
ASF GitHub Bot commented on SDAP-35:
------------------------------------
lewismc commented on a change in pull request #6: SDAP-35 (completed the
configuration change)
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172924479
##########
File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodConstants.java
##########
@@ -80,44 +90,80 @@
*/
public static final String ONTOLOGY_IMPL = MUDROD +
"ontology.implementation";
- public static final String ONTOLOGY_LINKAGE_TYPE = "ontologyLinkageType";
+ public static final String ONTOLOGY_LINKAGE_TYPE = "ontologyLinkage";
- public static final String ONTOLOGY_W = "ontology_w";
+ public static final String ONTOLOGY_W = "mudrod.ontology.weight";
+
+ public static final String ONTOLOGY_PATH = "mudrod.ontology.path";
+
+ public static final String ONTOLOGY_INPUT_PATH =
"mudrod.ontology.input.path";
- public static final String PROCESS_TYPE = "processingType";
+ public static final String PROCESS_TYPE = "mudrod.processing.type";
/** Defined on CLI */
- public static final String RAW_METADATA_PATH = "raw_metadataPath";
-
- public static final String RAW_METADATA_TYPE = "raw_metadataType";
-
- public static final String SEARCH_F = "searchf";
-
- public static final String SENDING_RATE = "sendingrate";
-
- public static final String SESSION_PORT = "SessionPort";
-
- public static final String SESSION_STATS_PREFIX = "SessionStats_prefix";
-
- public static final String SESSION_URL = "SessionUrl";
-
- public static final String SPARK_APP_NAME = "spark.app.name";
-
- public static final String SPARK_MASTER = "spark.master";
+ public static final String METADATA_DOWNLOAD = "mudrod.metadata.download";
+
+ public static final String RAW_METADATA_PATH = "mudrod.metadata.path";
+
+ public static final String RAW_METADATA_TYPE = "mudrod.metadata.type";
+
+ public static final String METADATA_MATRIX_PATH =
"mudrod.metadata.matrix.path";
+
+ public static final String METADATA_SVD_PATH = "mudrod.metadata.svd.path";
+
+ public static final String RECOM_METADATA_TYPE = "recommedation.metadata";
+
+ public static final String METADATA_ID = "mudrod.metadata.id";
+
+ public static final String SEMANTIC_FIELDS =
"mudrod.metadata.semantic.fields";
+
+ public static final String METADATA_WORD_SIM_TYPE = "metadata.word.sim";
+
+ public static final String METADATA_FEATURE_SIM_TYPE =
"metadata.feature.sim";
+
+ public static final String METADATA_SESSION_SIM_TYPE =
"metadata.session.sim";
+
+ public static final String METADATA_TERM_MATRIX_PATH =
"metadata.term.matrix.path";
+
+ public static final String METADATA_WORD_MATRIX_PATH =
"metadata.word.matrix.path";
+
+ public static final String METADATA_SESSION_MATRIX_PATH =
"metadata.session.matrix.path";
+
+ public static final String REQUEST_RATE = "mudrod.request.rate";
+
+ public static final String SESSION_PORT = "mudrod.session.port";
+
+ public static final String SESSION_STATS_TYPE = "sessionstats";
Review comment:
Should be ```session.stats```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Overhaul MUDROD configuration
> -----------------------------
>
> Key: SDAP-35
> URL: https://issues.apache.org/jira/browse/SDAP-35
> Project: Apache Science Data Analytics Platform
> Issue Type: Task
> Components: mudrod
> Reporter: Lewis John McGibbney
> Priority: Major
>
> [~Yongyao] please augment the description here with your intended patch as
> per https://github.com/aist-oceanworks/mudrod/pull/215
> Also, please name your branch and commit message after the issue you create
> in JIRA. It makes things much easier as we try to improve the quality of our
> source code review and development workflow. Thank you
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
