[ 
https://issues.apache.org/jira/browse/SDAP-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389980#comment-16389980
 ] 

ASF GitHub Bot commented on SDAP-35:
------------------------------------

lewismc commented on a change in pull request #6: SDAP-35 (completed the 
configuration change)
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172923662
 
 

 ##########
 File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodConstants.java
 ##########
 @@ -13,63 +13,73 @@
  */
 package org.apache.sdap.mudrod.main;
 
-import org.apache.sdap.mudrod.ontology.Ontology;
-
 /**
  * Class contains static constant keys and values relating to Mudrod
  * configuration properties. Property values are read from <a href=
  * 
"https://github.com/mudrod/mudrod/blob/master/core/src/main/resources/config.xml";>config.xml</a>
  */
 public interface MudrodConstants {
 
-  public static final String CLEANUP_TYPE_PREFIX = "Cleanup_type_prefix";
-
-  public static final String CLICK_STREAM_LINKAGE_TYPE = 
"clickStreamLinkageType";
+  public static final String CLEANUP_TYPE = "cleanupLog";
 
 Review comment:
   Here the value is camelCased. it should be 
   ```
   cleanup.log
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Overhaul MUDROD configuration
> -----------------------------
>
>                 Key: SDAP-35
>                 URL: https://issues.apache.org/jira/browse/SDAP-35
>             Project: Apache Science Data Analytics Platform
>          Issue Type: Task
>          Components: mudrod
>            Reporter: Lewis John McGibbney
>            Priority: Major
>
> [~Yongyao] please augment the description here with your intended patch as 
> per https://github.com/aist-oceanworks/mudrod/pull/215
> Also, please name your branch and commit message after the issue you create 
> in JIRA. It makes things much easier as we try to improve the quality of our 
> source code review and development workflow. Thank you



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to