lewismc commented on a change in pull request #6: SDAP-35 (completed the configuration change) URL: https://github.com/apache/incubator-sdap-mudrod/pull/6#discussion_r172946540
########## File path: core/src/main/java/org/apache/sdap/mudrod/ssearch/ranking/DataGenerator.java ########## @@ -34,10 +33,10 @@ private static boolean isMultFiles; private static String[] myHeader; - private static List<List<String>> myMasterList = new ArrayList<>(); + private static List<List<String>> myMasterList = new ArrayList<List<String>>(); // HashMap used for comparing evaluation classes - public static final Map<String, Integer> map1 = new HashMap<>(); + public static final HashMap<String, Integer> map1 = new HashMap<String, Integer>(); Review comment: Return types should not be concrete implementations if possible. Also use diamond operator ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
