fgreg commented on a change in pull request #7: SDAP-37 Update SolrProxy to
allow tile search by arbitrary tile metadata
URL: https://github.com/apache/incubator-sdap-nexus/pull/7#discussion_r173302837
##########
File path: data-access/nexustiles/nexustiles.py
##########
@@ -163,6 +163,20 @@ def find_tiles_in_polygon(self, bounding_polygon,
ds=None, start_time=0, end_tim
**kwargs)
return tiles
+ @tile_data()
+ def find_tiles_by_metadata(self, metadata, ds=None, start_time=0,
end_time=-1, **kwargs):
Review comment:
I think this needs to apply a mask for start/end time (and in fact we will
probably need to do this for most other methods in nexustileservice) since we
can no longer assume that the tile will only contain data relevant to the
requested start/end time. A tile might now partially overlap the requested time
frame, so we should mask the irrelevant data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
