[ 
https://issues.apache.org/jira/browse/SDAP-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391956#comment-16391956
 ] 

ASF GitHub Bot commented on SDAP-37:
------------------------------------

fgreg commented on a change in pull request #7: SDAP-37 Update SolrProxy to 
allow tile search by arbitrary tile metadata
URL: https://github.com/apache/incubator-sdap-nexus/pull/7#discussion_r173302837
 
 

 ##########
 File path: data-access/nexustiles/nexustiles.py
 ##########
 @@ -163,6 +163,20 @@ def find_tiles_in_polygon(self, bounding_polygon, 
ds=None, start_time=0, end_tim
                                                                      **kwargs)
         return tiles
 
+    @tile_data()
+    def find_tiles_by_metadata(self, metadata, ds=None, start_time=0, 
end_time=-1, **kwargs):
 
 Review comment:
   I think this needs to apply a mask for start/end time (and in fact we will 
probably need to do this for most other methods in nexustileservice) since we 
can no longer assume that the tile will only contain data relevant to the 
requested start/end time. A tile might now partially overlap the requested time 
frame, so we should mask the irrelevant data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Update SolrProxy to allow tile search by arbitrary tile metadata
> ----------------------------------------------------------------
>
>                 Key: SDAP-37
>                 URL: https://issues.apache.org/jira/browse/SDAP-37
>             Project: Apache Science Data Analytics Platform
>          Issue Type: New Feature
>            Reporter: Nga Chung
>            Assignee: Nga Chung
>            Priority: Major
>
> Besides searching for tiles by spatial and temporal parameters, enable 
> searching for tiles by custom tile metadata, such as river id.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to