lewismc commented on a change in pull request #7: SDAP-35 Overhaul MUDROD
configuration
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173496195
##########
File path: core/src/main/java/org/apache/sdap/mudrod/ssearch/Ranker.java
##########
@@ -35,14 +35,12 @@
*/
private static final long serialVersionUID = 1L;
transient List<SResult> resultList = new ArrayList<>();
-
- String learnerType = null;
Learner le = null;
- public Ranker(Properties props, ESDriver es, SparkDriver spark, String
learnerType) {
+ public Ranker(Properties props, ESDriver es, SparkDriver spark) {
super(props, es, spark);
- this.learnerType = learnerType;
- le = new Learner(learnerType, spark,
props.getProperty(MudrodConstants.SVM_SGD_MODEL));
+ if(props.getProperty(MudrodConstants.RANKING_ML).equals("1"))
Review comment:
The string value should be on the left hand side of the equals statement
e.g. ```
if("1".equals(props.getProperty(MudrodConstants.RANKING_ML)))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
