Yongyao commented on a change in pull request #7: SDAP-35 Overhaul MUDROD configuration URL: https://github.com/apache/incubator-sdap-mudrod/pull/7#discussion_r173500638
########## File path: core/src/main/java/org/apache/sdap/mudrod/weblog/structure/ApacheAccessLog.java ########## @@ -15,55 +15,49 @@ import com.google.gson.Gson; +import org.apache.sdap.mudrod.main.MudrodConstants; +import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection; + import java.io.IOException; import java.io.Serializable; import java.text.ParseException; import java.text.SimpleDateFormat; import java.util.Date; +import java.util.Properties; import java.util.regex.Matcher; import java.util.regex.Pattern; -import org.apache.sdap.mudrod.weblog.pre.CrawlerDetection; - /** * This class represents an Apache access log line. See * http://httpd.apache.org/docs/2.2/logs.html for more details. */ public class ApacheAccessLog extends WebLog implements Serializable { - - - /** - * - */ - private static final long serialVersionUID = 1L; - - public ApacheAccessLog() { - //default constructor - } - - String response; - String referer; - String browser; + String Response; Review comment: I suggest creating a new issue about lower/upper case. If I just change them to lower case here, lots of other code will be affected ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
