lewismc commented on a change in pull request #31: SDAP-118 create a new
ranking module
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199277549
##########
File path:
ranking/src/main/java/org/apache/sdap/mudrod/ranking/evaluate/ClickstreamImporter.java
##########
@@ -47,23 +47,20 @@ public ClickStreamImporter(Properties props, ESDriver es,
SparkDriver spark) {
* Method to add Elasticsearch mapping for click stream data
*/
public void addClickStreamMapping() {
- XContentBuilder mapping;
- String clickStreamMatrixType =
props.getProperty(MudrodConstants.CLICK_STREAM_MATRIX_TYPE);
+ XContentBuilder Mapping;
try {
- mapping = jsonBuilder()
- .startObject()
- .startObject(clickStreamMatrixType)
- .startObject("properties")
- .startObject("query").field("type",
"string").field("index", "not_analyzed").endObject()
- .startObject("dataID").field("type",
"string").field("index", "not_analyzed").endObject()
- .endObject()
- .endObject()
- .endObject();
+ Mapping = jsonBuilder().startObject().startObject(
Review comment:
Ideally these mapping should be made modular and configurable based on a
mapping file stored in ```/src/main/resources```, for the time being forget
about it but in the future we need to engineer these objects in a more sensible
manner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
