[
https://issues.apache.org/jira/browse/SDAP-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528248#comment-16528248
]
ASF GitHub Bot commented on SDAP-118:
-------------------------------------
lewismc commented on a change in pull request #31: SDAP-118 create a new
ranking module
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/31#discussion_r199276992
##########
File path:
ranking/src/main/java/org/apache/sdap/mudrod/ranking/common/Ranker.java
##########
@@ -160,11 +160,9 @@ public int compare(SResult o1, SResult o2) {
}
double[] ins = instList.stream().mapToDouble(i -> i).toArray();
- LabeledPoint insPoint = new LabeledPoint(99.0, Vectors.dense(ins));
- int prediction = (int)le.classify(insPoint);
+ int prediction = (int)le.predict(ins);
Review comment:
Is accuracy an issue here? We loose accuracy by casting to ```int```, is
this an issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> create a ranking module
> -----------------------
>
> Key: SDAP-118
> URL: https://issues.apache.org/jira/browse/SDAP-118
> Project: Apache Science Data Analytics Platform
> Issue Type: Sub-task
> Components: mudrod
> Affects Versions: 1.0
> Reporter: Yun Li
> Assignee: Yun Li
> Priority: Major
> Fix For: 1.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
