[
https://issues.apache.org/jira/browse/SDAP-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16679167#comment-16679167
]
ASF GitHub Bot commented on SDAP-165:
-------------------------------------
lewismc commented on a change in pull request #34: SDAP-165 Fix MUDROD bugs to
get master branch running
URL:
https://github.com/apache/incubator-sdap-mudrod/pull/34#discussion_r231742380
##########
File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
##########
@@ -391,7 +391,7 @@ public static void main(String[] args) {
me.end();
} catch (Exception e) {
HelpFormatter formatter = new HelpFormatter();
- formatter.printHelp("MudrodEngine: 'dataDir' argument is mandatory. " +
"User must also provide an ingest method.", options, true);
+ formatter.printHelp("MudrodEngine: 'dataDir' argument is mandatory. " +
"User must also provide an ingest method.", true);
Review comment:
@echyam this formatter should really just be replaced with a throw statement
for the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix MUDROD bugs to get master branch running
> --------------------------------------------
>
> Key: SDAP-165
> URL: https://issues.apache.org/jira/browse/SDAP-165
> Project: Apache Science Data Analytics Platform
> Issue Type: Bug
> Components: mudrod
> Reporter: Elizabeth Yam
> Assignee: Elizabeth Yam
> Priority: Major
>
> Current master branch does not work as is. Missing import statements, prints
> command line options during ingest, and expecting the wrong filename
> convention in config properties.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
