[ 
https://issues.apache.org/jira/browse/SDAP-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16713764#comment-16713764
 ] 

ASF GitHub Bot commented on SDAP-161:
-------------------------------------

lewismc commented on a change in pull request #35: SDAP-161 MUDROD embedded 
unit test
URL: 
https://github.com/apache/incubator-sdap-mudrod/pull/35#discussion_r240015405
 
 

 ##########
 File path: core/src/main/java/org/apache/sdap/mudrod/main/MudrodEngine.java
 ##########
 @@ -391,12 +391,12 @@ public static void main(String[] args) {
       me.end();
     } catch (Exception e) {
       HelpFormatter formatter = new HelpFormatter();
-      formatter.printHelp("MudrodEngine: 'dataDir' argument is mandatory. " + 
"User must also provide an ingest method.", true);
+      formatter.printHelp("MudrodEngine: 'dataDir' argument is mandatory. " + 
"User must also provide an ingest method.", options, true);
 
 Review comment:
   OK what I am saying is that this code should be changed to the following
   ```
   } catch (Exception e) {
     throw new RuntimeException(e)
   }
   ```
   ...or something similar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> MUDROD embedded unit test
> -------------------------
>
>                 Key: SDAP-161
>                 URL: https://issues.apache.org/jira/browse/SDAP-161
>             Project: Apache Science Data Analytics Platform
>          Issue Type: Improvement
>          Components: mudrod
>    Affects Versions: 1.0
>            Reporter: Yun Li
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to