jelya commented on a change in pull request #68: SDAP-192 Created DOMS netCDF reader tool. URL: https://github.com/apache/incubator-sdap-nexus/pull/68#discussion_r271477354
########## File path: tools/doms/doms_reader.py ########## @@ -0,0 +1,133 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import argparse +from netCDF4 import Dataset +import sys +import datetime +import csv +from collections import OrderedDict + +def assemble_matches(filename): + """ + Read a DOMS netCDF file and return a list of matches. + + Arguments: + filename (string): the DOMS netCDF file name. + + Returns: + matches (list): List of matches. Each list element is a dictionary: + For netCDF group GROUP (SatelliteData or InsituData) and group + variable VARIABLE: + matches[GROUP]['matchID']: MatchedRecords dimension ID for the match + matches[GROUP]['GROUPID']: GROUP dim dimension ID for the record + matches[GROUP][VARIABLE]: variable value + """ + # Open the netCDF file. + try: + doms_nc = Dataset(filename, 'r') Review comment: I added a doms_nc.close() statement to address this so that I could keep the try/except block. Or would one of [these solutions](https://stackoverflow.com/questions/5627425/what-is-a-good-way-to-handle-exceptions-when-trying-to-read-a-file-in-python) be better? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
