eamonford commented on a change in pull request #4:
URL:
https://github.com/apache/incubator-sdap-ingester/pull/4#discussion_r445821134
##########
File path: collection_manager/containers/docker/entrypoint.sh
##########
@@ -0,0 +1,10 @@
+#!/bin/bash
+
+python /collection_manager/collection_manager/main.py \
+ $([[ ! -z "$COLLECTIONS_PATH" ]] && echo
--collections-path=$COLLECTIONS_PATH) \
+ $([[ ! -z "$RABBITMQ_HOST" ]] && echo --rabbitmq-host=$RABBITMQ_HOST) \
Review comment:
These lines will convert environment variables into command line
parameters to send to the collection manager script. While it is not strictly
necessary, it is a good way of encapsulating the command line syntax of the
script and isolating it from the Kubernetes template that launches the docker
container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
