skorper opened a new pull request #46: URL: https://github.com/apache/incubator-sdap-ingester/pull/46
In order to support Gregorian calendar types, I updated the Julian check to check instead for the base class `cftime.datetime`. This means this code will run for both Julian and Gregorian calendar types, and will not run when the data in the `time` variable was already automatically converted to a primitive data type. This change has been made for both `GridReadingProcessor` and `GridMultiVariableReadingProcessor`. I've added unit tests for both processors, testing for the following cases: |Format|Dataset|Granule| |--|--|--| |Standard|OISSS|`OISSS_L4_multimission_global_7d_v1.0_2021-03-12.nc`| |Julian|GPM|`3B-DAY-E.MS.MRG.3IMERG.20070101-S000000-E235959.V06.nc4`| |Gregorian|COVERAGE|`20190630_d-ACRI-L4-CHL-MULTI_4KM-GLO-REP.nc`| |Missing|MUR-SST|`20181231090000-JPL-L4_GHRSST-SSTfnd-MUR25-GLOB-v02.0-fv04.2.nc`| -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
