If NASA has contributed these files to SDAP we’re fine. 

Julian

> On Dec 19, 2022, at 5:51 PM, Stepheny Perez <skpe...@apache.org> wrote:
> 
> Hi Julian,
> 
> Those are test files, some are custom but some aren’t. For example 
> 20181231090000-JPL-L4_GHRSST-SSTfnd-MUR25-GLOB-v02.0-fv04.2.nc is a publicly 
> accessible NASA file. Would you advise us to remove these? 
> 
> Thanks,
> Stepheny
> 
> 
>> On 2022/12/20 00:17:00 Julian Hyde wrote:
>> The vote email is much improved; thank you!
>> 
>> I downloaded the artifacts using svn, checked signatures (.asc files),
>> LICENSE, NOTICE, DISCLAIMER, VERSION.txt, file headers; I verified
>> that the contents of each tar file matches the corresponding git
>> commit. Checked for binary files.
>> 
>> I see that hashes of the src.tar.gz files have changed since the
>> previous rc2 vote, and they are signed with your key rather than Nga's
>> key. That's OK.
>> 
>> I see that sdap-ingester contains some large binary files with .nc,
>> .h5 and .nc4 suffixes. Are those files covered by the Apache license?
>> Are they generated? (It's OK to include binary files in a release,
>> provided that the project owns the copyright, but not OK to include
>> generated files.) I am going to assume that they are owned by the
>> project and not generated; please let me know if I am mistaken.
>> 
>> +1 (binding)
>> 
>> Julian
>> 
>> PS Riley: Yes, you definitely can vote. RMs usually add the following
>> line to their vote emails: "Here's my vote: +1 (binding)".
>> 
>> PPS Since we have one only one active mentor, I am going to ask other
>> IPMC members to take a look at these artifacts and vote. Even if they
>> discover problems that I have not, it will still help us get to a good
>> release faster.
>> 
>>> On Mon, Dec 19, 2022 at 11:17 AM Riley Kuttruff <r...@apache.org> wrote:
>>> 
>>> +1 from me too if I can.
>>> 
>>> Riley
>>> 
>>> On 2022/12/19 19:05:43 Stepheny Perez wrote:
>>>> +1
>>>> 
>>>> Stepheny
>>>> 
>>>> On 2022/12/19 18:58:47 Riley Kuttruff wrote:
>>>>> Hello everyone,
>>>>> 
>>>>> This is the second attempt to approve Apache SDAP (incubating) release 
>>>>> candidate rc2 for version 1.0.0.
>>>>> 
>>>>> There were no changes to the code between this and the previous attempt 
>>>>> to release rc2.
>>>>> 
>>>>> Changes made between previous candidate (rc1) and this one (rc2) are as
>>>>> follows:
>>>>> - Added README
>>>>> - Added DISCLAIMER
>>>>> 
>>>>> Instructions for building docker images from source can be found here:
>>>>> https://incubator-sdap-nexus.readthedocs.io/en/latest/build.html
>>>>> Instructions for deploying locally to test can be found here:
>>>>> https://incubator-sdap-nexus.readthedocs.io/en/latest/quickstart.html
>>>>> 
>>>>> The tags to be voted on are 1.0.0-rc2:
>>>>> 
>>>>> - nexusproto:
>>>>>    - URL: 
>>>>> https://github.com/apache/incubator-sdap-nexusproto/tree/1.0.0-rc2
>>>>>    - Commit: f3c726e69997436dd9ee6f9a993d4c95ee490b6f
>>>>> - ingester:
>>>>>    - URL: https://github.com/apache/incubator-sdap-ingester/tree/1.0.0-rc2
>>>>>    - Commit: 2c8a9d35320f11a5db2534802f43366ddaff2fea
>>>>> - nexus:
>>>>>    - URL: https://github.com/apache/incubator-sdap-nexus/tree/1.0.0-rc2
>>>>>    - Commit: f60e98331ac29b57ca40322f8f96e98a5c69e553
>>>>> 
>>>>> The release files, including signatures, digests, etc. can be found at:
>>>>> https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.0.0-rc2/
>>>>> 
>>>>> For verification, the hashes (SHA-512) of the .tar.gz artifacts we are 
>>>>> voting on are as follows:
>>>>> 
>>>>> apache-sdap-ingester-1.0.0-src.tar.gz:
>>>>> db380c3002351e65ec3581a3ff0cacbb7092f46292b0a656a78a919e1409738442e845731050a2160a556a7818f22b2ab4bb6da437200bc0a62419332de49ad7
>>>>> 
>>>>> apache-sdap-nexus-1.0.0-src.tar.gz:
>>>>> da34e9830cf5126bac498180d7cdd95bc2cfc13535c7b4355ba51de64e3589a385a969e0cf1a89fa77e436b30c99a48abffab4b4ef03b23982aa33c2e83e8dbd
>>>>> 
>>>>> apache-sdap-nexusproto-1.0.0-src.tar.gz:
>>>>> 05dc8e96d9c49207750c1da13f630493e8d08f5e68733742c157ac6c85ede29aca25f3c94cd706acbbe21cee41ebc052a880b4d6ce859bf510bcc2d66d8f88b2
>>>>> 
>>>>> Release artifacts are signed with the following key:
>>>>> https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x4e98c4a32026656e14e0b570fc20035a010e3b7b
>>>>> 
>>>>> Please vote on releasing this package as Apache SDAP (incubating) 1.0.0.
>>>>> 
>>>>> The vote is open for 72 hours and passes if at least 3 +1 PMC votes are
>>>>> cast.
>>>>> 
>>>>> PLEASE NOTE: Do not reply with a vote from your work email as it can 
>>>>> mangle the links. To vote, go to 
>>>>> https://lists.apache.org/list.html?dev@sdap.apache.org, log in and send 
>>>>> your reply from there.
>>>>> 
>>>>> [ ] +1 Release this package as Apache SDAP (incubating) 1.0.0
>>>>> [ ] +0 No opinion
>>>>> [ ] -1 Do not release this package because ...
>>>>> 
>>>>> Thank you,
>>>>> Riley
>>>>> 
>>>> 
>> 

Reply via email to