I validated this release like so: - Manually built and deployed Docker images - Deployed latest helm charts - Tested /apidocs -- endpoint working as expected - Tested /match_spark -- endpoint working as expected - Tested /domslist -- endpoint working as expected - Tested /cdmssubset -- endpoint working as expected - Ran quick start locally with latest ingester image -- data/metadata looks correct
+1 On 2023/01/09 21:01:51 Julian Hyde wrote: > Downloaded artifacts, checked signatures and hashes, checked NOTICE > (noted updated year), LICENSE, DISCLAIMER-WIP, file headers. > > I compared each tarball with the contents of git as of the commit > described in the voe email. I noted that gradle-wrapper.jar is no > longer in apache-sdap-nexusproto tarball. > > Thanks for adding a prefix to the files in the tar.gz files; per > standard practice I would have skipped the 'Apache-SDAP' prefix and > left only the 'apache-sdap-xxx-1.0.0-incubating-src' prefix; this is > not a reason to vote against. > > Here is my vote: +1 (binding) > > Julian > > On Wed, Jan 4, 2023 at 1:52 PM Riley Kuttruff <r...@apache.org> wrote: > > > > Hello everyone, > > > > This is the vote to approve Apache SDAP (incubating) release candidate rc3 > > for version 1.0.0. > > > > Changes made between previous candidate (rc2) and this one (rc3) are as > > follows: > > - Switched to DISCLAIMER-WIP > > - Removed Gradle wrapper from nexusproto source distribution & updated > > developer build instruction for nexusproto > > - Updated release artifact structure to extract to single common directory > > & updated release build instructions accordingly > > - Corrected NOTICE file and updated copyright statement to reflect correct > > years > > - Updated naming for release artifacts > > (apache-sdap-{module}-{version}-src.tar.gz -> > > apache-sdap-{module}-{version}-incubating-src.tar.gz) > > > > Instructions for building docker images from source can be found here: > > https://github.com/apache/incubator-sdap-nexus/blob/b6d002cc7f7192820ce9f4443cee9867d3bdbdd0/docs/build.rst > > Instructions for deploying locally to test can be found here: > > https://incubator-sdap-nexus.readthedocs.io/en/latest/quickstart.html > > > > The release files, including signatures, digests, etc. can be found at: > > https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.0.0-rc3/ > > > > For convenience, the tags we built the release artifacts to be voted on > > from are 1.0.0-rc3: > > > > - nexusproto: > > - URL: https://github.com/apache/incubator-sdap-nexusproto/tree/1.0.0-rc3 > > - Commit: cc35046cd72d9e749a33b697c58e5ca9ccec5711 > > - ingester: > > - URL: https://github.com/apache/incubator-sdap-ingester/tree/1.0.0-rc3 > > - Commit: ae25aae70cc9b91bd0b05788e88e77edc77f0fd3 > > - nexus: > > - URL: https://github.com/apache/incubator-sdap-nexus/tree/1.0.0-rc3 > > - Commit: bf65205c8dae838d95843de34c94d6d46a579308 > > > > For verification, the hashes (SHA-512) of the .tar.gz artifacts we are > > voting on are as follows: > > > > apache-sdap-ingester-1.0.0-incubating-src.tar.gz: > > f97f932d3f9c937316fd07f17d27af6f567681c9b9c5e3a4d9813a3372673e829455c96eed10e356200d7a6829d0ec178aff458b8138f0656698f06ca0e8d413 > > > > apache-sdap-nexus-1.0.0-incubating-src.tar.gz: > > 10d491484ff23cf670fd955c576deadea99d976e776b07457f0b38df9c8b06018e0a54888a5ee0704d44a01b83e57b518de6d72ad6d5b28b14cf557054ea54ca > > > > apache-sdap-nexusproto-1.0.0-incubating-src.tar.gz: > > 1a42e02e859de639fc44a4900dccfa9815dbbde8aabf705600478ccf0d6d46cb98d2a8f76841cbce3bff15f08739725dc39af5e0e8ca052fe6dbf2ed2ed26032 > > > > Release artifacts are signed with the following key: > > https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x4e98c4a32026656e14e0b570fc20035a010e3b7b > > > > Please vote on releasing this package as Apache SDAP (incubating) 1.0.0. > > > > The vote is open for 72 hours and passes if at least 3 +1 PMC votes are > > cast. > > > > PLEASE NOTE: Do not reply with a vote from your work email as it can mangle > > the links. To vote, go to > > https://lists.apache.org/list.html?dev@sdap.apache.org, log in and send > > your reply from there. > > > > [ ] +1 Release this package as Apache SDAP (incubating) 1.0.0 > > [ ] +0 No opinion > > [ ] -1 Do not release this package because ... > > > > Thank you, > > Riley >