skorper commented on code in PR #261:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/261#discussion_r1279709780


##########
analysis/webservice/algorithms/doms/BaseDomsHandler.py:
##########
@@ -94,6 +94,10 @@ def __init__(self, results=None, args=None, bounds=None, 
count=None, details=Non
         self.__details = details
         self.__executionId = str(executionId)
 
+        # Add page num and size to details block
+        self.__details['pageNum'] = page_num
+        self.__details['pageSize'] = page_size

Review Comment:
   Ah I see, you meant check if `__details` was None, I had assumed you meant 
to check if page_num/page_size is None. Agreed, that seems wise



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to