skorper commented on code in PR #275:
URL: 
https://github.com/apache/incubator-sdap-nexus/pull/275#discussion_r1323774412


##########
analysis/webservice/algorithms/doms/ResultsStorage.py:
##########
@@ -192,7 +192,9 @@ def __insertResults(self, execution_id, results):
         inserts = []
 
         for result in results:
-            inserts.extend(self.__prepare_result(execution_id, None, result, 
insertStatement))
+            # 'PRIMARY' arg since primary values cannot have primary_value_id 
be null anymore
+            # Secondary matches are prepped recursively from this call
+            inserts.extend(self.__prepare_result(execution_id, 'PRIMARY', 
result, insertStatement))

Review Comment:
   Ohhh gotcha. This is literally being inserted into the DB as a stand-in. 
Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@sdap.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to