+1 (binding) Verified as follows:
- Ran regression tests for Matchup and Matchup related endpoints - Ran through quickstart docs and confirmed expected behavior - Confirmed expected behavior on both local deployment and AWS EKS deployment. Stepheny On 2023/10/31 18:40:54 Nga Chung wrote: > I verified the release as follows: > - Verified artifacts checksums and signatures > - Successfully built local images per build.rst > - Ran through notebook per quickstart.rst. Encountered an issue with > solr-cloud-init image but changing > https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc2/docker/solr/cloud-init/Dockerfile#L17 > to FROM python:3.11 worked. Created a ticket > https://issues.apache.org/jira/browse/SDAP-496. I don't consider this > as a blocker for this release. Also had an issue with running > nexus-webapp with Docker Desktop on my M2 Mac, but enabling "Use > Rosetta for x86/amd64 emulation on Apple Silicon" fixed the issue. > Thanks to Riley for helping me with these issues. > > +1 from me (binding) > > Thanks, > Nga > > > > > > > > On Mon, Oct 30, 2023 at 2:01 PM Julian Hyde <jh...@apache.org> wrote: > > > > +1 (binding) > > > > Downloaded, checked signatures, LICENSE, NOTICE, DISCLAIMER; compared > > against git tags; ran docker build; checked licenses. > > > > Note: I followed the instructions at > > https://incubator-sdap-nexus.readthedocs.io/en/latest/build.html. > > Copy-pasting twenty or so shell commands to perform a build seemed > > like rather a lot. If there's any way to reduce that effort (e.g. > > shipping a build script) I would appreciate it. > > > > Julian > > > > > > On Fri, Oct 27, 2023 at 9:50 AM Riley Kuttruff <r...@apache.org> wrote: > > > > > > I verified: > > > - Release commits > > > - Artifact signatures & checksums > > > - Images built successfully > > > - Components work successfully > > > > > > +1 (binding) > > > > > > -Riley > > > > > > On 2023/10/27 04:23:57 Stepheny Perez wrote: > > > > Hello everyone, > > > > > > > > This is the vote to approve Apache SDAP (incubating) release candidate > > > > rc2 for version 1.2.0. > > > > > > > > CHANGELOG for version 1.2.0 are available here: > > > > https:/github.com/apache/incubator-sdap-ingester/blob/1.2.0-rc2/CHANGELOG.md > > > > https:/github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc2/CHANGELOG.md > > > > > > > > Changes made between previous candidate (rc1) and this one (rc2) are as > > > > follows: > > > > > > > > - Fix build issues with Apple Silicon M1/M2 > > > > - Install protobuf through PyPi instead of from source > > > > > > > > Instructions for building docker images from source can be found here: > > > > https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc2/docs/build.rst > > > > Instructions for deploying locally to test can be found here: > > > > https://github.com/apache/incubator-sdap-nexus/blob/1.2.0-rc2/docs/quickstart.rst > > > > The release files, including signatures, digests, etc. can be found at: > > > > https://dist.apache.org/repos/dist/dev/incubator/sdap/apache-sdap-1.2.0-rc2/ > > > > > > > > For convenience, the tags we built the release artifacts to be voted on > > > > from are 1.2.0-rc2: > > > > > > > > - ingester: > > > > - URL: https://github.com/apache/incubator-sdap-ingester/tree/1.2.0-rc2 > > > > - Commit: a9f0673abdd8fc5aebbbcd3051ba43f6f7f040fe > > > > > > > > - nexus: > > > > - URL: https://github.com/apache/incubator-sdap-nexus/tree/1.2.0-rc2 > > > > - Commit: 955938afddd8824b1240b1582355f941f2139dec > > > > > > > > For verification, the hashes (SHA-512) of the .tar.gz artifacts we are > > > > voting on are as follows: > > > > > > > > apache-sdap-ingester-1.2.0-incubating-src.tar.gz: > > > > 9717675657a7f6cdf38f6a965fcee70fc602a4d1d879c45f93df5824d09375a088a81e9f5ffdba4b8c9aeb46ccec89fff732fb3899734b4a59eaf99668ee6c15 > > > > > > > > apache-sdap-nexus-1.2.0-incubating-src.tar.gz: > > > > ea5eb29f69d4955c0bfdca9af0be193eb0ed05555c5fc6750cbb51f2b5e1796fa8fe73e17b72a92a22831fd7fdefa1b33378a753a083697913c95dc645c76c5a > > > > > > > > Release artifacts are signed with the following key: > > > > https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x2E8418801953621FAA322169D6F360887071C194 > > > > > > > > Please vote on releasing this package as Apache SDAP (incubating) 1.2.0. > > > > > > > > The vote is open for 72 hours and passes if at least 3 +1 PMC votes are > > > > cast. > > > > > > > > PLEASE NOTE: Do not reply with a vote from your work email as it can > > > > mangle the links. To vote, go to > > > > https://lists.apache.org/list.html?dev@sdap.apache.org, log in and send > > > > your reply from there. > > > > > > > > [ ] +1 Release this package as Apache SDAP (incubating) 1.2.0 > > > > [ ] +0 No opinion > > > > [ ] -1 Do not release this package because ... > > > > > > > > Thank you, > > > > Stepheny > > > > >
