funky-eyes commented on code in PR #5399:
URL: https://github.com/apache/incubator-seata/pull/5399#discussion_r1435630294
##########
tcc/src/main/java/io/seata/rm/tcc/interceptor/parser/TccActionInterceptorParser.java:
##########
@@ -15,62 +15,60 @@
*/
package io.seata.rm.tcc.interceptor.parser;
+import java.lang.reflect.Method;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Set;
+
import io.seata.common.util.ReflectionUtil;
-import io.seata.integration.tx.api.interceptor.TxBeanParserUtils;
import io.seata.integration.tx.api.interceptor.handler.ProxyInvocationHandler;
import
io.seata.integration.tx.api.interceptor.parser.DefaultResourceRegisterParser;
+import io.seata.integration.tx.api.interceptor.parser.IfNeedEnhanceBean;
import io.seata.integration.tx.api.interceptor.parser.InterfaceParser;
-import io.seata.integration.tx.api.remoting.RemotingDesc;
+import io.seata.integration.tx.api.interceptor.parser.NeedEnhanceEnum;
import io.seata.integration.tx.api.remoting.parser.DefaultRemotingParser;
import io.seata.rm.tcc.api.TwoPhaseBusinessAction;
import io.seata.rm.tcc.interceptor.TccActionInterceptorHandler;
-import java.lang.reflect.Method;
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.Set;
-
/**
* @author leezongjie
*/
public class TccActionInterceptorParser implements InterfaceParser {
@Override
public ProxyInvocationHandler parserInterfaceToProxy(Object target, String
objectName) {
- boolean isTxRemotingBean = TxBeanParserUtils.isTxRemotingBean(target,
objectName);
Review Comment:
> 我是这样考虑的：io.seata.integration.tx.api.util.ProxyUtil#createProxy(T,
java.lang.String)，用户在使用这个api的时候，创建代理的时候，肯定是要对带有二阶段注解的业务类进行代理，所以这里不需要在这里判断这个类是不是remoteBean（dubbo,
sofa等）。举例：如果用户使用的是dubbo或者sofa，那么在使用api的方式创建代理，那么应该首先对原生的带有二阶段注解的业务类使用createProxy方法生成代理bean，然后再把这个bean配置再dubbo或者sofa所有指向的ref引用。
我们不能假定用户的行为,所以还是需要检测,并且这个方法应该增加相关注释以便用户理解和使用
We cannot assume user behavior, so we still need to detect it, and this
method should add relevant comments for users to understand and use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
