Bughue commented on code in PR #6208:
URL: https://github.com/apache/incubator-seata/pull/6208#discussion_r1438081626
##########
core/src/main/java/io/seata/core/rpc/netty/v1/ProtocolV1Encoder.java:
##########
@@ -92,7 +92,7 @@ public void encode(ChannelHandlerContext ctx, Object msg,
ByteBuf out) {
if (messageType != ProtocolConstants.MSGTYPE_HEARTBEAT_REQUEST
&& messageType !=
ProtocolConstants.MSGTYPE_HEARTBEAT_RESPONSE) {
// heartbeat has no body
- Serializer serializer =
SerializerServiceLoader.load(SerializerType.getByCode(rpcMessage.getCodec()));
+ Serializer serializer =
SerializerServiceLoader.load(SerializerType.getByCode(rpcMessage.getCodec()),
ProtocolConstants.VERSION_1);
Review Comment:
here https://github.com/apache/incubator-seata/pull/6226
CompatibleProtocolDecoder will chose ProtocolDecoderV0,and ProtocolDecoderV0
will provide v0 parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
