funky-eyes commented on code in PR #6234:
URL: https://github.com/apache/incubator-seata/pull/6234#discussion_r1440242706
##########
all/pom.xml:
##########
@@ -368,6 +368,7 @@
<dependency>
<groupId>com.alibaba</groupId>
<artifactId>druid</artifactId>
+ <scope>provided</scope>
Review Comment:
seata强依赖druid
sqlparser做sql的解析，你为什么要将其scope改为provided，如果你有依赖冲突，应该解决你的依赖冲突问题，而不是提pr到社区粗暴的解决
Seata strong dependency druid sqlparser does sql parsing, why do you want to
change its scope to provided, if you have dependency conflicts, you should
solve your dependency conflicts instead of mentioning pr to the community for
rough resolution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
