Agree.This will be more user-friendly for users who submit PR for the first time, making it easier for them to identify issues in a timely manner.
Best Regards, Jiangke Wu Jianbin Chen <jian...@apache.org> 于2024年4月30日周二 15:58写道： > Hello members of the Apache Seata community, > > I will be submitting a proposal on Apache JIRA aimed at ensuring that > GitHub Actions workflows can run smoothly for all PRs submitted by > contributors to all incubator-seata repositories, without requiring > approval from committer/PPMC members. > > I've noticed that in the incubator-seata-sample repository, PRs require > approval from committer/PPMC members in order for GitHub CI to run. This > means that while reviewing code, we often have to wait for the GitHub > Actions workflow to complete. If the workflow result is abnormal, we then > have to conduct code reviews again, leading to a waste of time for everyone > involved. It would be much more efficient if we only needed to review code > when the GitHub Actions workflow result is successful. > > The proposed strategy for Fork pull request workflows from outside > collaborators is to "Require approval for first-time contributors". > > I encourage everyone to vote and share their opinions on this matter. > > Jianbin Chen, githubId: funky-eyes >
