Hi Sheng,

I have made corrections to the issue you raised. Please check for any
obvious issue first; if there are none, I will repackage and initiate
a new round of voting.

> 1. `incubating` doesn't exist for source tar and binary. This is
> required by the incubator

The source package will be named
`apache-seata-2.1.0-incubating-src.zip`, and the binary package will
be named `apache-seata-2.1.0-incubating-bin.zip`.


> 2. LICENSE in the source tar seems to include all dependencies
> licenses, which is wrong. Only the LICENSE in the binary should
> include those, the LICENSE in the source tar should indicate codes
> copied from other projects.

source license: https://github.com/apache/incubator-seata/blob/2.x/LICENSE
binary license:
https://github.com/apache/incubator-seata/blob/2.x/distribution/LICENSE


> 3. The NOTICE file in the source tar should include the NOTICE files
> from the copied codes repository if they are licensed through APLv2.
> The NOTICE file in the binary tar should include contents of the
> NOTICE file from APLv2 dependencies.

The source code does not copy any code based on APLv2, so the NOTICE
file in the source code only contains information about Seata itself.
source NOTICE: https://github.com/apache/incubator-seata/blob/2.x/NOTICE
binary NOTICE: 
https://github.com/apache/incubator-seata/blob/2.x/distribution/NOTICE

> 4. DISCLAIMER doesn't exist in the binary tar.

The binary package after the next build will include a DISCLAIMER file.



Warm regards,


Ji Min

Sheng Wu <wu.sheng.841...@gmail.com> 于2024年6月7日周五 22:08写道:
>
> -1 binding
>
> I can compile from the source.
> LICENSE and NOTICE exist
> ASC checked
> sha512 exists
>
> The issues are
> 1. `incubating` doesn't exist for source tar and binary. This is
> required by the incubator
> 2. LICENSE in the source tar seems to include all dependencies
> licenses, which is wrong. Only the LICENSE in the binary should
> include those, the LICENSE in the source tar should indicate codes
> copied from other projects.
> 3. The NOTICE file in the source tar should include the NOTICE files
> from the copied codes repository if they are licensed through APLv2.
> The NOTICE file in the binary tar should include contents of the
> NOTICE file from APLv2 dependencies.
> 4. DISCLAIMER doesn't exist in the binary tar.
>
> Sheng Wu 吴晟
> Twitter, wusheng1108
>
> jsbxyyx <jsbx...@apache.org> 于2024年6月7日周五 10:17写道:
>
>
> >
> > +1 binding from jsbxyyx
> >
> > [x] Download links are valid.
> >
> > [x] Checksums and signatures.
> >
> > [x] LICENSE/NOTICE files exist
> >
> > [x] All source files have ASF headers
> >
> > Min Ji <ji...@apache.org> 于2024年6月4日周二 14:12写道:
> >
> > > Hi Seata Community,
> > >
> > > This is a call for vote on releasing Apache Seata(incubating)
> > > 2.1.0-RC3. This is the first release of Apache Seata(incubating).
> > >
> > > The release candidates:
> > >
> > > https://dist.apache.org/repos/dist/dev/incubator/seata/incubator-seata/2.1.0/
> > >
> > > The staging repo:
> > > https://repository.apache.org/content/repositories/orgapacheseata-1010/
> > >
> > > Git tag for the release:
> > > https://github.com/apache/incubator-seata/releases/tag/v2.1.0
> > >
> > > Hash for the release tag:
> > > 295c3dbe3c212c01d751627466cd0e36fe2b7516
> > >
> > > Release Notes:
> > > https://github.com/apache/incubator-seata/releases/tag/v2.1.0
> > >
> > > The artifacts have been signed with Key :
> > > B51F1A5056BC5D6FBF2D82871E90338E9FA7635C, which can be found in the
> > > keys file:
> > > https://dist.apache.org/repos/dist/dev/incubator/seata/KEYS
> > >
> > > Build Environment: JDK 8+, Apache Maven 3.6.0+.
> > > Build Command: ./mvnw clean package -DskipTests=true ,
> > > If you are building on an ARM64 architecture, please add the profile
> > > -Parrch64.
> > >
> > > CI Test Workflow:
> > >
> > > https://github.com/apache/incubator-seata/actions/runs/9360495157/job/25766545149
> > >
> > > The vote will be open for at least 72 hours or until necessary number
> > > of votes are reached.
> > >
> > > Please vote accordingly:
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > Thanks,
> > > The Apache Seata Team
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@seata.apache.org
> > > For additional commands, e-mail: dev-h...@seata.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@seata.apache.org
> For additional commands, e-mail: dev-h...@seata.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@seata.apache.org
For additional commands, e-mail: dev-h...@seata.apache.org

Reply via email to