I would like to know the community's thoughts on this proposal. Are there any other contributors who would like to join the discussion? If not, I believe we can begin working on this proposal after a week.
Best Regards. Jianbin Chen, github-id: funky-eyes Jianbin Chen <jian...@apache.org> 于 2025年2月22日周六 20:31写道： > You're right, I totally agree. > > Best Regards！ > Jianbin Chen, github-id: funky-eyes > > Yongjun Hong <dev.yongj...@gmail.com> 于 2025年2月22日周六 17:52写道： > >> Your comment is very well thought out, and I completely agree with both of >> the considerations you've raised. >> >> The second point, in particular, is crucial since it will make merging >> existing PRs quite challenging. I believe this is something that should be >> carefully discussed. >> >> However, as the saying goes, "You can’t make an omelet without breaking a >> few eggs." In other words, some sacrifices are inevitable for the sake of >> significant progress. Additionally, except for a few PRs, most have not >> been updated in a while, so I think closing them would be reasonable. >> >> Best Regards >> Yongjun Hong, github-id: Yonggoose >> >> >> > I support this proposal, but two important considerations must be noted: >> > >> > Developers must use JDK 11 or higher for compilation (this requirement >> is >> > only for automatic formatting and does not impose a minimum JDK version >> > restriction on users). >> > >> > Once this plugin is introduced, the pull request (PR) will inevitably >> cause >> > significant conflicts with all existing PRs. >> > >> > Nevertheless, I still endorse this proposal, just as I had submitted a >> > similar one to the community a few years ago. >> > >> > Best Regards！ >> > Jianbin Chen, github-id: funky-eyes >> > >> > Yongjun Hong <dev.yongj...@gmail.com> 于 2025年2月22日周六 17:30写道： >> > >> > > Dear Seata community, >> > > >> > > Checkstyle is a great tool for maintaining code formatting, but it >> only >> > > points out issues without automatically fixing them. On the other >> hand, >> > > Spotless provides an apply feature that can automatically format the >> > code, >> > > making it much more convenient to use.Since Seata is an open-source >> > project >> > > under Apache, developers from all over the world contribute to it. >> While >> > it >> > > would be ideal if everyone were already familiar with Alibaba's >> > Checkstyle >> > > rules, many contributors, including myself, may not be. >> > > >> > > With that in mind, adopting Spotless could be a good option. For >> > reference, >> > > JUnit, a project I have contributed to multiple times, has integrated >> > > Spotless, and I found it to be very convenient. What do you think >> about >> > > using Spotless? >> > > >> > > Best regards, >> > > Yongjun >> > > >> > > PS. Dubbo community is using the Spotless plugin. >> > > >> > > >> > >> https://github.com/apache/dubbo/blob/cedc58316ddce533644aa627e5233711907c2e62/pom.xml#L172 >> > > >> > > Related document >> > > - https://github.com/diffplug/spotless >> > > >> > >> >
