GitHub user YongGoose added a comment to the discussion: Whether or not bug

> I was mistaken about the implementation; it is indeed implemented as a 
> singleton return. I think we should change List to Set for simplicity.

The current implementation of `RegistryService` doesn’t override equals and 
hashCode.
So if we use a `Set`, I think logically identical instances could end up being 
stored as duplicates.

GitHub link: 
https://github.com/apache/incubator-seata/discussions/7342#discussioncomment-13227726

----
This is an automatically sent email for dev@seata.apache.org.
To unsubscribe, please send an email to: dev-unsubscr...@seata.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@seata.apache.org
For additional commands, e-mail: dev-h...@seata.apache.org

Reply via email to