tachibana22 opened a new pull request, #98:
URL: https://github.com/apache/incubator-seata-go-samples/pull/98

   **What this PR does**:
   In the AT mode server samples (`at/gin`, `at/rollback`), database operation 
errors were caught but the wrapper functions incorrectly returned `nil`. This 
behavioral defect led the system to report success to the Transaction 
Coordinator (TC) even when SQL executions failed, thereby bypassing the global 
rollback mechanism. This PR fixes the issue by explicitly returning the `err` 
to ensure the rollback logic is correctly triggered.
   
   **Which issue(s) this PR fixes**:
   Fixes #97
   
   **The related PR of seata-go**:
   None
   
   **You should pay attention to items below to ensure your pr passes our ci 
test**
   We do not merge pr with ci tests failed
   
   - [x] All ut passed (run 'go test ./...' in project root)
   - [x] After go-fmt ed , run 'go fmt project' using goland.
   - [x] Golangci-lint passed, run 'sudo golangci-lint run' in project root.
   - [ ] Your new-created file needs to have [apache license]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to