Hi jiajie,
Thanks for the reminder, I found a problem, it seems that the final merge will 
be based on the first PR-title, I will check the PR title and make changes 
during the merge, but sometimes I forget to change the corresponding git log 
header during the merge.
Is there an automated way for us to do this?


Best wishes!
Calvin Kirs


On 02/16/2022 11:22,Jiajie Zhong<[email protected]> wrote:
Hey guys,

I found out some of our commit title is meaningless, which you
can see in https://github.com/apache/incubator-seatunnel-website/commits/main 
<https://github.com/apache/incubator-seatunnel-website/commits/main>
and https://github.com/apache/incubator-seatunnel/commits/dev 
<https://github.com/apache/incubator-seatunnel/commits/dev>.

We have more in the website repo. I think when contributors submit PR should
make the title more meaningful. And when committer merging PR, should change
the title if not meaningful.

Some rules I think we should avoid it:

* A single word in the PR:
* 
https://github.com/apache/incubator-seatunnel/commit/64695611545fc459f9d0aa802dbb74ac29351a9d
 
<https://github.com/apache/incubator-seatunnel/commit/64695611545fc459f9d0aa802dbb74ac29351a9d>
* 
https://github.com/apache/incubator-seatunnel-website/commit/d10241c7d038e9a3680af9694a41938bb6dfa484
 
<https://github.com/apache/incubator-seatunnel-website/commit/d10241c7d038e9a3680af9694a41938bb6dfa484>
* Only fix in specific issue, like `fix #123`: 
https://github.com/apache/incubator-seatunnel/commit/3e7d04bcbcf0224d1530a278e92bea8375d3151c
 
<https://github.com/apache/incubator-seatunnel/commit/3e7d04bcbcf0224d1530a278e92bea8375d3151c>

We also have some best practices in
https://github.com/apache/incubator-seatunnel/commit/9268133a810f81cf168a77eb450fde74f05ad4c9
 
<https://github.com/apache/incubator-seatunnel/commit/9268133a810f81cf168a77eb450fde74f05ad4c9>
which includes the module an overview of this change

Cheers,
— Jiajie Zhong

Reply via email to