+1, It is a good practice to separate the lib directory from the starter directory.
TaoZex <[email protected]> 于2022年10月21日周五 11:51写道： > I agree with hailin0's suggestion. > > > ------------------ 原始邮件 ------------------ > 发件人: > "dev" > < > [email protected]>; > 发送时间: 2022年10月21日(星期五) 上午10:58 > 收件人: "dev"<[email protected]>; > > 主题: Re: [DISCUSS] Add SPI directory to binary package to support SPI > plug-in > > > > I propose that we create `${seatunnel-home}/starter` directory and move the > engine starter package in this directory. > > Using `${seatunnel-home}/lib` as the classpath for all engines, you can > copy any packages into this directory, e.g spi jar. > > Change before: > apache-seatunnel-incubating-${version} > - - bin > - - config > - - connectors > - - plugins > - - licenses > - - lib > - - seatunnel-spark-starter.jar > - - seatunnel-flink-starter.jar > - - seatunnel-core-spark.jar > - - seatunnel-core-flink.jar > - - seatunnel-core-flink-sql.jar > - - seatunnel-starter.jar > > Change after: > apache-seatunnel-incubating-${version} > - - bin > - - config > - - connectors > - - plugins > - - licenses > - - starter > - - seatunnel-spark-starter.jar > - - seatunnel-flink-starter.jar > - - seatunnel-core-spark.jar > - - seatunnel-core-flink.jar > - - seatunnel-core-flink-sql.jar > - - seatunnel-starter.jar > - - lib > - - xxx.jar > - - ...... > > > > Zongwen Li <[email protected]> 于2022年10月19日周三 13:38写道： > > > Currently we support format and catalog features, which support SPI, > > but do not support plug-in loading. > > At the same time, our existing PluginDiscovery and `plugins` are > > related to the engine, and the new features are not related to the > > engine. > > So I expected to add the `spi` directory to support plugins when > packaging: > > "spi/catalog": catalog factory > > "spi/format": format factory > > "spi/transform": transform factory > > > > -- > > Best Regards, > > > > Zongwen Li > > -- Best Regards ------------ EricJoy2048 [email protected]
