Re: [DISCUSS] Remove lombok in SeaTunnel

[Lucifer Tyrant]

Hi ZhangJian,

1. In past weekly meetings, it was mentioned that @Data can cause
unexpected issues with the equals and hashcode methods, reference:
https://github.com/apache/seatunnel/issues/4150

2. When use @Builder，@NoArgsConstructor will conflict with it.

3. The readability of the code will become very poor.

Chao Tian

ZhangJian He <shoot...@gmail.com> 于2023年12月2日周六 11:33写道：
>
> Hi, There are also well-known projects using lombok, like Apache Pulsar
> etc. Could you please share more details about lombok's problems.
>
> Thanks
> ZhangJian He
>
>
> On Sat, 2 Dec 2023 at 11:21, Carl-Zhou-CN <1058249...@qq.com.invalid> wrote:
>
> > +1
> >
> >
> > 121
> > 1058249...@qq.com
> >
> >
> >
> > &nbsp;
> >
> >
> >
> >
> > ------------------ 原始邮件 ------------------
> > 发件人:
> >                                                   "dev"
> >                                                                 <
> > tyrantluci...@apache.org&gt;;
> > 发送时间:&nbsp;2023年12月1日(星期五) 晚上10:33
> > 收件人:&nbsp;"dev"<dev@seatunnel.apache.org&gt;;
> >
> > 主题:&nbsp;[DISCUSS] Remove lombok in SeaTunnel
> >
> >
> >
> > Hi developers,
> >
> > In the recent development process, I discovered an issue with Lombok.
> > Lombok can cause overloading of multi parameter constructors to fail,
> > resulting in generated code that may not meet expectations and loss of
> > readability. After comparing with other well-known projects such as
> > Flink and Kafka, I found that Lombok plugins were not used. Therefore,
> > I would like to propose to remove all Lombok plugins from the main
> > repository
> >
> > What do you think about this? If you have any advice, please let me know.
> >
> > Chao Tian