Hi Felix,

Thank you very much for your comments.

For your comments,

1. Fixed. The rebuilt and signed tarballs are on
https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.0-incubating-rc1/
2. Fixed. I use "apache-sedona-1.0.0-incubating-src"
and "apache-sedona-1.0.0-incubating-bin". "1.0.0" is before "incubating",
this is to make it consistent with the version number in POM.

For the staging repo, I just staged all artifacts on repository.apache.org.

For the typos and broken links in compile doc, I have fixed them and moved
this to "Publish code": https://sedona.staged.apache.org/download/publish/.
The "compile code" is still available:
https://sedona.staged.apache.org/download/compile/

Regards,
Jia

On Sat, Jan 23, 2021 at 5:46 PM Felix Cheung <felixche...@apache.org> wrote:

> 1/ the tarball should unpack to incubator-sedona-sedona-1.0.0-incubating
> and not incubator-sedona-sedona-1.0.0-incubating-rc1 - this is because once
> the vote is passed, you will not be rebuilding the tarball - as the one we
> voted on, signed etc, that one will be the actual release.
>
> 2. also typically the name of the unpacked directory should
> be apache-sedona-incubating-1.0.0-src (the tarball should be
> named apache-sedona-incubating-1.0.0-src.tar.gz)
>
> So let's rebuild the tarball, resign - we don't have to change the git tag
> (so the source doesn't have to be reviewed again)
>
> additional notes:
>
> You can actually stage artifacts on repository.apache.org without having
> it
> published - in the staging repo
> https://repository.apache.org/content/groups/staging/org/apache/
>
> These links on the compile page for the website seems wrong (
> https://sedona.staged.apache.org/sedona.apache.org)
> also there is a typo "will"
>
>    1. Use the copied content to replace all content in asf-site branch and
>    upload to GitHub. Then sedona.apache.org
>    <https://sedona.staged.apache.org/sedona.apache.org> wil be
>    automatically updated.
>    2. You can also push the content to asf-staging branch. The staging
>    website will be then updated: sedona.staged.apache.org
>    <https://sedona.staged.apache.org/sedona.staged.apache.org>
>
> Checklist verified:
> - incubating in name
> - signature and hash fine
> - DISCLAIMER is fine
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - All source files have ASF headers
> - compile from source
>
>
> On Wed, Jan 20, 2021 at 12:26 AM Jia Yu <jiayu198...@gmail.com> wrote:
>
> > Hi all,
> >
> > This is a call for vote on Apache Sedona (incubating) 1.0.0 rc1. Please
> > refer to the changes listed at the bottom of this email.
> >
> > Release note:
> >
> >
> https://sedona.staged.apache.org/download/GeoSpark-All-Modules-Release-notes/#sedona-100
> >
> > Build instructions:
> > https://sedona.staged.apache.org/download/compile/
> >
> > GitHub tag:
> >
> >
> https://github.com/apache/incubator-sedona/releases/tag/sedona-1.0.0-incubating-rc1
> >
> > GPG public key to verify the Release:
> > https://dist.apache.org/repos/dist/dev/incubator/sedona/KEYS
> >
> > Source code and binaries:
> >
> >
> https://dist.apache.org/repos/dist/dev/incubator/sedona/1.0.0-incubating-rc1/
> >
> > The vote will be open for at least 72 hours or until a majority of at
> least
> > 3 +1 PMC votes are cast
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> >
> > [ ] +0 no opinion
> >
> > [ ] -1 disapprove with the reason
> >
> > Checklist for reference (because of DISCLAIMER-WIP, other checklist items
> > are not blockers):
> >
> > [ ] Download links are valid.
> >
> > [ ] Checksums and PGP signatures are valid.
> >
> > [ ] DISCLAIMER is included.
> >
> > [ ] Source code artifacts have correct names matching the current
> release.
> >
> > For a detailed checklist  please refer to:
> >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >
> > Changes from the last failed vote (let's call it rc0 :-) ):
> > 1. Version changed from "1.0.0-incubator" to "1.0.0-incubating"
> > 2. Source code and binary now hosted on dist/dev/incubator/sedona/
> > 3. Source code and binary now are signed by RSA-4096 key with
> > ji...@apache.org
> > 4. Source code and binary now use sha512 checksum
> > 5. Binaries are not staged on repository.apache.org yet. I will stage
> them
> > after the vote passes.
> > 6. The compressed source code size changed from 600+ MB to 100+ MB, by
> > remove duplicate test data. Will find a way to further in the future
> > releases.
> > 7. GeoTools (LGPL license, ASF Category X license) binaries have been
> > completed removed from Sedona binaries. Users have to compile the source
> > code by themselves if they want to use ShapefileReader and CRS
> > Transformation.
> >
> > @fengji...@gmail.com <fengji...@gmail.com> Von, the GitHub tag is called
> > "sedona-1.0.0-incubating-rc1" which has "sedona" prefix. This is because
> > our GitHub tags include old tags for GeoSpark. To differentiate Sedona
> tags
> > from old tags, I intend to add the "sedona" prefix.
> >
> > Thank you very much!
> > Jia
> >
>

Reply via email to