jiayuasu commented on a change in pull request #514:
URL: https://github.com/apache/incubator-sedona/pull/514#discussion_r592738688



##########
File path: 
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala
##########
@@ -727,6 +728,88 @@ case class ST_MinimumBoundingCircle(inputExpressions: 
Seq[Expression])
 }
 
 
+/**
+ * Return a linestring being a substring of the input one starting and ending 
at the given fractions of total 2d length.
+ * Second and third arguments are Double values between 0 and 1. This only 
works with LINESTRINGs.
+ *
+ * @param inputExpressions
+ */
+case class ST_LineSubString(inputExpressions: Seq[Expression])

Review comment:
       Thank you for your contribution! Not sure whether or not Spark function 
name is case sensitive or not. So would you please change the name to 
'ST_LineSubstring' to make it consistent with PostGIS? 
https://postgis.net/docs/ST_LineSubstring.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to