jiayuasu commented on pull request #525:
URL: https://github.com/apache/incubator-sedona/pull/525#issuecomment-842730237


   @yitao-li This looks good to me. I actually ran into this issue before but 
wasn't able to identify the issue. Thanks for pointing this out. If you can add 
some test cases, I will accept this PR immediately.
   
   ImmutableGeometry may not be a good choice because many geoms in JTS 
directly extend Geometry. If we add a ImmutableGeometry, we have to develop 
corresponding wrappers for all different geom types, which is not practical I 
believe


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to