jiayuasu commented on pull request #536: URL: https://github.com/apache/incubator-sedona/pull/536#issuecomment-897054243
@swamirishi Thanks for your great work. This PR sounds interesting to me. However, this seems to be a big PR so we need to have a thorough review for this. So far, this PR contains many file changes: 47 files changed so far. Can you avoid changing POM files unless it is necessary? Currently, you duplicate the dependencies to different Sedona modules. Please only keep your changes to Sedona core module if possible. This will be helpful for us to review. Can you also make your PR pass our CI test? @Imbruced @netanel246 @Sarwat Folks, please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
