jiayuasu commented on a change in pull request #536:
URL: https://github.com/apache/incubator-sedona/pull/536#discussion_r695540349
##########
File path: core/src/main/java/org/apache/sedona/core/spatialRDD/SpatialRDD.java
##########
@@ -129,9 +138,24 @@
* The sample number.
*/
private int sampleNumber = -1;
-
- public int getSampleNumber()
- {
+ /**
+ * Geometry Type Defaults to Geometry Collection
+ */
+ private GeometryType geometryType;
+
+ public SpatialRDD() {
Review comment:
Is there a reason why you need to add geometry type to SpatialRDD?
Because you need to use this information to define the type of geospatial
objects in a Parquet file?
I don't think this is a good idea. Currently, this generic SpatialRDD is not
bounded to a particular type. It allows mixed spatial objects in an RDD. E.g.,
POINT (XXX)
POLYGON (XXX)
MULTIPOLYGON (XXX)
POINT (XXX)
This scenario is actually quite common in real world. A WKT file of state
boundaries or country boundaries may consist of both POLYGON and MULTIPOLYGON.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
