jiayuasu commented on pull request #584: URL: https://github.com/apache/incubator-sedona/pull/584#issuecomment-1047214262
@madzik555 Wait, I think we had a miscommunication here. Your implementation for null safe ST_Difference was correct. The expression should extend "BinaryGeometryExpression" which is automatically null safe. What @Imbruced asked is that just add some "null" test cases in https://github.com/apache/incubator-sedona/pull/580 So for ST_SymDifference, you should also extend "BinaryGeometryExpression". I believe your old implementation was correct, but the one we merged into the master branch didn't extend "BinaryGeometryExpression"... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
